This repository was archived by the owner on Jan 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
[WIP] SEP: Master topology #73
Open
dwoz
wants to merge
1
commit into
saltstack:master
Choose a base branch
from
dwoz:master-topology
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
- Feature Name: (fill with a unique identifier, ex: my-awesome-feature) | ||
- Start Date: (fill with today's date, YYYY-MM-DD) | ||
- SEP Status: Draft | ||
- SEP PR: (leave this empty) | ||
- Salt Issue: (leave this empty) | ||
|
||
# Summary | ||
[summary]: #summary | ||
|
||
There is a well proven want and need of Salt users to be able to group minions | ||
into a single master logically and/or physically. Add the ablity | ||
to link master's together and target different masters. | ||
|
||
# Motivation | ||
[motivation]: #motivation | ||
|
||
There is a well proven want and need of Salt users to be able to group minions | ||
into a single master logically and/or physically. Historically Synic has been | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. *Syndic |
||
used to achive these kinds of groupings. The intention of this SEP is to create | ||
a more robust solutions which will eventually deprecate Synics by building this | ||
functionality directly into Salt Masters. | ||
|
||
# Design | ||
[design]: #detailed-design | ||
|
||
Add the ability to define a topology of masters. Each node under topology is a | ||
master. Users will be able to target jobs based on which master the minion is | ||
connected to in addition to our existing targeting options. | ||
|
||
``` | ||
topology: | ||
- west: | ||
- west-dc-1: | ||
- rack1 | ||
- rack2 | ||
- rack3 | ||
- west-dc-2: | ||
- rack1 | ||
- rack3 | ||
- rack3 | ||
- west-dc-2: | ||
- rack1 | ||
- rack3 | ||
- rack3 | ||
- east: | ||
- east-dc-1: | ||
- rack1 | ||
- rack2 | ||
- rack3 | ||
- east-dc-2: | ||
- rack1 | ||
- rack3 | ||
- rack3 | ||
``` | ||
|
||
|
||
## Alternatives | ||
[alternatives]: #alternatives | ||
|
||
What other designs have been considered? What is the impact of not doing this? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here would be a good place to show the equivalent Syndic solution for the example problem, highlighting its issues. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The targeting problem can be trivially solved with minion ids that reflect the topology. What specifically would this proposal add? |
||
|
||
## Unresolved questions | ||
[unresolved]: #unresolved-questions | ||
|
||
What parts of the design are still TBD? | ||
|
||
# Drawbacks | ||
[drawbacks]: #drawbacks | ||
|
||
Why should we *not* do this? Please consider: | ||
|
||
- Implementation cost, both in term of code size and complexity | ||
- Integration of this feature with other existing and planned features | ||
- Cost of migrating existing Salt setups (is it a breaking change?) | ||
- Documentation (would Salt documentation need to be re-organized or altered?) | ||
|
||
|
||
There are tradeoffs to choosing any path. Attempt to identify them here. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[citation needed]