Open
Conversation
waynew
suggested changes
Jul 11, 2022
Contributor
waynew
left a comment
There was a problem hiding this comment.
I will definitely need to do a more in-depth review, along with building some sample module.run states to run against this, but at the very least the unit tests need some upgrades, and integration tests are also a requirement.
| @patch.object(nsxt_request, "call_api") | ||
| def test_get_using_basic_auth(mock_call_api): | ||
|
|
||
| mock_call_api.return_value = _mock_edge_clusters |
Contributor
There was a problem hiding this comment.
suggestion these should be converted to fixtures. At a glance it looks like there should be two fixtures:
@pytest.fixture
def mock_success_api_call(mock_call_api):
mock_call_api.return_value = {...} # _mock_edge_clusters
yield mock_call_api
@pytest.fixture
def mock_failure_api_call(mock_call_api):
mock_call_api.return_value = {...} # error_json
yield mock_call_api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.