Fix 'NameError: name 'datacenter_name' is not defined' in vmware_vm.relocate#280
Fix 'NameError: name 'datacenter_name' is not defined' in vmware_vm.relocate#280ggiesen wants to merge 3 commits intosaltstack:mainfrom
Conversation
|
Okay, so obviously I like this change, I've been working to try and figure out how to adjust some things. I mentioned this over in #255 but as you may know, we made some trade-offs at the start of the project that are rapidly needing to be traded... back on? 😂 Basically, for the integration tests, we need fixtures that will actually connect to vSphere and:
There may be some other vSphere resources that we need -- I'm still not 100% comfortable will all the requirements when it comes to managing ESXi 😂 but I'm getting there. One thing that we could do here is just write a simple unit test that mocks out the pyvmomi parts within the utils - that should be pretty easy to get to appropriately fail, so this fix can be tested -- at least if we want to merge before building out the full integration tests, which I'm fine with. As long as we have some test coverage to make sure that everything is being called in at least a reasonable fashion. |
|
@ggiesen, VMware has approved your signed contributor license agreement. |
Fixes bad variable reference by either allowing you to specify
datacenter_nameor by callingutils_datastore.get_datastoreswithout it.Fixes: #279