[CoE] Content libraries #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy18
suggested changes
Jan 13, 2023
Contributor
dmurphy18
left a comment
dmurphy18
left a comment
There was a problem hiding this comment.
quick glance over the files, and noted we need to get the copyright and license statements in there. This probably needs to be done for all files to be compliant with the Open Source Office.
| @@ -0,0 +1,127 @@ | |||
| # Copyright 2021 VMware, Inc. | |||
| @@ -0,0 +1,91 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| @@ -0,0 +1,116 @@ | |||
| """ | |||
| @@ -0,0 +1,155 @@ | |||
| """ | |||
jgangel
force-pushed
the
content-library-only
branch
from
c6e59a9 to
3f5224c
Compare
waynew
suggested changes
Jan 19, 2023
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Haven't checked the rest of this PR yet, but it does need a changelog 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes modules, state and their corresponding unit tests for content libraries