Compatibility for systemd >= 249 hostnamectl#63438
Closed
eliasp wants to merge 3 commits intosaltstack:masterfrom
Closed
Compatibility for systemd >= 249 hostnamectl#63438eliasp wants to merge 3 commits intosaltstack:masterfrom
hostnamectl#63438eliasp wants to merge 3 commits intosaltstack:masterfrom
Conversation
s0undt3ch
previously approved these changes
Jan 9, 2023
Ch3LL
suggested changes
Jan 9, 2023
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
Can you add a changelog for this change
systemd 249 changed the verb `set-hostname` of `hostnamectl` to just `hostname`. While the previous one is expected to remain available for the time being, make sure the new one is used when appropriate to prevent any issues in the future once the `set-hostname` form will be removed.
Ch3LL
force-pushed
the
hostnamectl-249
branch
from
34c85da to
69c714b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemd 249 changed the verb
set-hostnameofhostnamectlto justhostname.While the previous one is expected to remain available for the time being, make sure the new one is used when appropriate to prevent any issues in the future once the
set-hostnameform will be removed.What does this PR do?
What issues does this PR fix or reference?
Fixes: --
Previous Behavior
The functions
network.mod_hostnameandsystem.set_computer_descusedhostnamectl set-hostnameto control the (pretty) hostname of a system.New Behavior
The functions
network.mod_hostnameandsystem.set_computer_descusehostnamectl hostname(instead of... set-hostname)to control the (pretty) hostname of a system when the used systemd version is equal or greater than249.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes