Skip to content

[master] Feature: salt.states.virt support on_crash, on_poweroff and on_lockfailure#64166

Closed
darshanip wants to merge 7 commits intosaltstack:masterfrom
darshanip:master
Closed

[master] Feature: salt.states.virt support on_crash, on_poweroff and on_lockfailure#64166
darshanip wants to merge 7 commits intosaltstack:masterfrom
darshanip:master

Conversation

@darshanip
Copy link

@darshanip darshanip commented Apr 26, 2023

Fixes #60699

What does this PR do?

What issues does this PR fix or reference?

#60699

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

version added is left to update
@darshanip darshanip requested a review from a team as a code owner April 26, 2023 14:49
@darshanip darshanip requested review from Ch3LL and removed request for a team April 26, 2023 14:49
@welcome
Copy link

welcome bot commented Apr 26, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Feature: salt.states.virt support on_crash, on_poweroff and on_lockfailure [master] Feature: salt.states.virt support on_crash, on_poweroff and on_lockfailure Apr 26, 2023
@darshanip darshanip marked this pull request as draft April 26, 2023 14:50
@darshanip darshanip marked this pull request as ready for review April 26, 2023 15:13
@darshanip darshanip temporarily deployed to ci April 26, 2023 16:46 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 26, 2023 16:49 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 26, 2023 17:06 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 26, 2023 18:49 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 26, 2023 18:49 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 26, 2023 18:49 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 30, 2023 09:09 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 30, 2023 09:09 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 30, 2023 09:10 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 30, 2023 13:40 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 30, 2023 13:40 — with GitHub Actions Inactive
@darshanip darshanip temporarily deployed to ci April 30, 2023 13:40 — with GitHub Actions Inactive
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a changelog

an auto-installation needing a special first boot configuration.
Defaults to ``False``

.. versionadded:: 3007
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change all of the 3007 versions to 3007.0

@dwoz dwoz added this to the Argon v3008.0 milestone Dec 18, 2023
@darshanip darshanip closed this by deleting the head repository Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] salt.states.virt: support on_crash

5 participants