Skip to content

Comments

[master] Add execution and state modules to manage Grafana via grafana-cli#65249

Closed
vincent-olivert-riera wants to merge 10 commits intosaltstack:masterfrom
vincent-olivert-riera:master
Closed

[master] Add execution and state modules to manage Grafana via grafana-cli#65249
vincent-olivert-riera wants to merge 10 commits intosaltstack:masterfrom
vincent-olivert-riera:master

Conversation

@vincent-olivert-riera
Copy link

@vincent-olivert-riera vincent-olivert-riera commented Sep 21, 2023

What does this PR do?

Adds execution and state modules for managing Grafana via grafana-cli.

The interfacing with grafana-cli is not complete. As a start I just added support for a few basic things that allow installing and removing plugins. Support for more stuff can be added in the future when required.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

This is a new Salt execution module aimed to interface with grafana-cli.

As a starting point, only listing installed plugins is supported.
This interfaces with "grafana-cli plugins list-versions <plugin id>".
This function will be used by a future function for performing the
installation. The goal of this function is to determine the actions of
the other function while providing status information.
This interfaces with "grafana-cli plugins install <plugin id> [version]".
This interfaces with `grafana-cli plugins remove <plugin id>`.
This is a new Salt state module which makes use of the grafana_cli
execution module.

As a starting point, only installing plugins is supported.
This state ensures a Grafana plugin is removed.
@welcome
Copy link

welcome bot commented Sep 21, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add execution and state modules to manage Grafana via grafana-cli [master] Add execution and state modules to manage Grafana via grafana-cli Sep 21, 2023
@vincent-olivert-riera vincent-olivert-riera marked this pull request as ready for review September 21, 2023 09:20
@vincent-olivert-riera vincent-olivert-riera requested a review from a team as a code owner September 21, 2023 09:20
@vincent-olivert-riera vincent-olivert-riera requested review from MKLeb and removed request for a team September 21, 2023 09:20
@s0undt3ch
Copy link
Contributor

This is all new code, I would suggest publishing it as a Salt Extensions, look here for other salt extensions and inspiration.

@vincent-olivert-riera
Copy link
Author

This is all new code, I would suggest publishing it as a Salt Extensions, look here for other salt extensions and inspiration.

Hi Pedro, thanks for your suggestion. I was aware of Salt Extensions, but still I would prefer to publish it directly on this repository.

@dwoz dwoz added this to the Argon v3008.0 milestone Dec 18, 2023
@dwoz dwoz requested a review from a team as a code owner March 16, 2025 22:09
@twangboy
Copy link
Contributor

twangboy commented Apr 4, 2025

Starting in Salt 3008 non-core Execution and State modules have been migrated to community support. There is a GitHub org set up for this purpose: https://github.com/salt-extensions. This code would be better served as a salt-extension.

There is currently discussion and work being done on the salt-extensions Discord channel (https://discordapp.com/channels/1200072194781368340/1208165123240370197) to document and build the infrastructure for community-supported salt extensions. There is also a Salt-Extensions Working Group that takes place on the 1st and 3rd Thursday of every month to coordinate salt-extension efforts.

@twangboy twangboy closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants