Skip to content

Comments

[3006.x] Add coverage contexts to show what tests touch which files#65297

Merged
dwoz merged 1 commit intosaltstack:3006.xfrom
MKLeb:coverage/3006.x/show-contexts
Jun 27, 2025
Merged

[3006.x] Add coverage contexts to show what tests touch which files#65297
dwoz merged 1 commit intosaltstack:3006.xfrom
MKLeb:coverage/3006.x/show-contexts

Conversation

@MKLeb
Copy link
Contributor

@MKLeb MKLeb commented Sep 26, 2023

What does this PR do?

Adds contexts to our coverage html reports. This will allow us to see which files touched what lines.

NOTE: We want to publish the json reports for this to GH Actions artifact storage, as they are the best format to parse out the contexts.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@MKLeb MKLeb requested a review from a team as a code owner September 26, 2023 19:47
@MKLeb MKLeb requested review from whytewolf and removed request for a team September 26, 2023 19:47
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add coverage contexts to show what tests touch which files [3006.x] Add coverage contexts to show what tests touch which files Sep 26, 2023
@MKLeb MKLeb requested review from s0undt3ch and removed request for whytewolf September 26, 2023 19:48
s0undt3ch
s0undt3ch previously approved these changes Sep 26, 2023
@MKLeb MKLeb added the test:full Run the full test suite label Sep 26, 2023
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 20:04 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 20:04 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 20:04 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 20:04 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 20:22 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 20:28 — with GitHub Actions Inactive
@MKLeb MKLeb force-pushed the coverage/3006.x/show-contexts branch from 444b4cb to ce863d0 Compare September 26, 2023 21:46
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 22:04 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 22:04 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 22:04 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 22:04 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 22:18 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 26, 2023 22:21 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 27, 2023 01:45 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 27, 2023 01:45 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 27, 2023 01:45 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 27, 2023 01:45 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 27, 2023 01:45 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 27, 2023 01:45 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 27, 2023 04:41 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci September 27, 2023 04:41 — with GitHub Actions Inactive
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we doing codecove right now? How much work would it take to get this in?

@dwoz dwoz added the test:full Run the full test suite label Apr 27, 2025
@dwoz dwoz self-assigned this May 11, 2025
@dwoz dwoz modified the milestones: Sulfur v3006.12, Sulfer v3006.13 Jun 13, 2025
@dwoz dwoz force-pushed the coverage/3006.x/show-contexts branch from bea62fe to 9b343d4 Compare June 27, 2025 22:18
@dwoz dwoz merged commit 6b8aacc into saltstack:3006.x Jun 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:coverage test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants