[master] Distribute virtualenv_mod in the windows packages#65672
Closed
Lesvek wants to merge 1 commit intosaltstack:masterfrom
Closed
[master] Distribute virtualenv_mod in the windows packages#65672Lesvek wants to merge 1 commit intosaltstack:masterfrom
Lesvek wants to merge 1 commit intosaltstack:masterfrom
Conversation
Due to an oversight the virtualenv_mod module was not distributes with the Windows package anymore.
salt-project-bot-prod-environment
bot
changed the title
Contributor
|
I brought your commit over to #67963. I would have updated this PR, but I didn't have permission. Closing this in favor of the above PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an oversight the virtualenv_mod module was not distributes with the Windows package anymore.
What does this PR do?
Add the virtualenv_mod module back in the windows packages
What issues does this PR fix or reference?
Fixes: In the step of removing the modules that are not compatible with Windows, we want to remove the virt package. The way the code works, it deletes every packages that match the virt* glob, which also includes virtualenv_mod.
New Behavior
We specify the file extension so virtualenv_mod.py is not deleted anymore.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No