[master] Fix S3 module: config.option returns empty string not None#65685
[master] Fix S3 module: config.option returns empty string not None#65685mirceaulinic wants to merge 1 commit intosaltstack:masterfrom
Conversation
This commit revisits saltstack#56220, hopefully this time won't take 3 more years. The reasoning of this change is that ``__salt__['config.option']`` can never return ``None``: ```bash {u'tgt': u''} ``` As a result some statements are never evaluated properly, and this module misbehaving.
salt-project-bot-prod-environment
bot
changed the title
|
@mirceaulinic This needs a changelog and regression test. |
|
@dwoz happy to add regression tests, would you help me find where are the current tests for the S3 module? |
|
This module and its associated states and tests have been transitioned to community support and are no longer maintained by the Salt Core team. The code has been removed from the Salt code-base and can be found in this repository: https://github.com/salt-extensions/community-extensions-holding/ There is currently discussion and work being done on the salt-extensions Discord channel (https://discordapp.com/channels/1200072194781368340/1208165123240370197) to document and build the infrastructure for community-supported salt extensions. There is also a Salt-Extensions Working Group that takes place on the 1st and 3rd Thursday of every month to coordinate salt-extension efforts. |
3 participants
This commit revisits #56220, hopefully this time won't take 3 more years. The reasoning of this change is that
__salt__['config.option']can never returnNone:{u'tgt': u''}As a result some statements are never evaluated properly, and this module misbehaving.