Skip to content

Comments

[master] Add timeout parameter to lxc.stop#65700

Closed
gregorg wants to merge 4 commits intosaltstack:masterfrom
gregorg:add-timeout-to-lxc-stop
Closed

[master] Add timeout parameter to lxc.stop#65700
gregorg wants to merge 4 commits intosaltstack:masterfrom
gregorg:add-timeout-to-lxc-stop

Conversation

@gregorg
Copy link

@gregorg gregorg commented Dec 14, 2023

What does this PR do?

Add parameter timeout to lxc.stop module.

@gregorg gregorg requested a review from a team as a code owner December 14, 2023 12:55
@gregorg gregorg requested review from twangboy and removed request for a team December 14, 2023 12:55
@welcome
Copy link

welcome bot commented Dec 14, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add timeout parameter to lxc.stop [master] Add timeout parameter to lxc.stop Dec 14, 2023
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changelog entry and preferably a test too.

@dwoz dwoz added this to the Argon v3008.0 milestone Dec 18, 2023
@dwoz
Copy link
Contributor

dwoz commented Dec 18, 2023

@gregorg pre-commit is now failing.

@gregorg gregorg requested a review from dwoz December 20, 2023 09:37
@gregorg
Copy link
Author

gregorg commented Jan 3, 2024

This needs a changelog entry and preferably a test too.

Done.

@dwoz dwoz requested a review from a team as a code owner March 16, 2025 22:09
@twangboy
Copy link
Contributor

twangboy commented Apr 2, 2025

This module and its associated states and tests have been transitioned to community support and are no longer maintained by the Salt Core team. The code has been removed from the Salt code-base and can be found in this repository: https://github.com/salt-extensions/community-extensions-holding/

There is currently discussion and work being done on the salt-extensions Discord channel (https://discordapp.com/channels/1200072194781368340/1208165123240370197) to document and build the infrastructure for community-supported salt extensions. There is also a Salt-Extensions Working Group that takes place on the 1st and 3rd Thursday of every month to coordinate salt-extension efforts.

@twangboy twangboy closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants