Skip to content

Comments

[master] Add external account binding parameters to acme module#66137

Closed
jsandas wants to merge 2 commits intosaltstack:masterfrom
jsandas:acme_support_external_account_binding
Closed

[master] Add external account binding parameters to acme module#66137
jsandas wants to merge 2 commits intosaltstack:masterfrom
jsandas:acme_support_external_account_binding

Conversation

@jsandas
Copy link

@jsandas jsandas commented Feb 25, 2024

What does this PR do?

See issue for details

What issues does this PR fix or reference?

Fixes: #66100

Previous Behavior

ACME module does not support external account binding

New Behavior

ACME module provides support for external account binding via eab_keyid and eab_hmac paramenters.

Merge requirements satisfied?

Commits signed with GPG?

Yes

@jsandas jsandas requested a review from a team as a code owner February 25, 2024 04:11
@jsandas jsandas requested review from whytewolf and removed request for a team February 25, 2024 04:11
@welcome
Copy link

welcome bot commented Feb 25, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add external account binding parameters to acme module [master] Add external account binding parameters to acme module Feb 25, 2024
@dwoz
Copy link
Contributor

dwoz commented Feb 26, 2024

@jsandas The acme module is slated for removal as a community maintained extension in 3008.0. Do you have any desire to maintain it?

@dwoz dwoz requested a review from a team as a code owner March 16, 2025 22:09
@twangboy
Copy link
Contributor

This module and its associated states and tests have been transitioned to community support and are no longer maintained by the Salt Core team. The code has been removed from the Salt code-base and can be found in this repository: https://github.com/salt-extensions/community-extensions-holding/

There is currently discussion and work being done on the salt-extensions Discord channel (https://discordapp.com/channels/1200072194781368340/1208165123240370197) to document and build the infrastructure for community-supported salt extensions. There is also a Salt-Extensions Working Group that takes place on the 1st and 3rd Thursday of every month to coordinate salt-extension efforts.

@twangboy twangboy closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support external account binding in acme module

3 participants