[3007.x] fix sync_renderers failure when the custom renderer is specified via config#66454
Merged
dwoz merged 3 commits intosaltstack:3007.xfrom Aug 4, 2025
Conversation
salt-project-bot-prod-environment
bot
changed the title
salt-project-bot-prod-environment
bot
changed the title
twangboy
previously approved these changes
May 13, 2024
dmurphy18
previously requested changes
Oct 21, 2024
Contributor
dmurphy18
left a comment
dmurphy18
left a comment
There was a problem hiding this comment.
Need to ensure ran pre-commit install to ensure you have cleaned up pre-commit errors before running the PR builds etc.
twangboy
previously approved these changes
Feb 12, 2025
Contributor
|
@nicholasmhughes The conflicts need to be addressed for this one to proceed. |
twangboy
force-pushed
the
fix-failed-render-when-syncing-renderers
branch
from
64b84c6 to
b026b64
Compare
twangboy
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See issue for details.
What issues does this PR fix or reference?
Fixes #66453
Previous Behavior
exception is raised when renderer in pipe fails to be found
New Behavior
renderer falls back to default if any renderer in pipe fails to be found
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.