Skip to content

Comments

[3006.x] Include the VM name with the IP address for Libvirt cloud logging#66860

Closed
m0duspwnens wants to merge 2 commits intosaltstack:3006.xfrom
m0duspwnens:libvirt-create-log-name-with-address
Closed

[3006.x] Include the VM name with the IP address for Libvirt cloud logging#66860
m0duspwnens wants to merge 2 commits intosaltstack:3006.xfrom
m0duspwnens:libvirt-create-log-name-with-address

Conversation

@m0duspwnens
Copy link

What does this PR do?

This PR adds the VM name to the log output for Libvirt when the IP address is reported. This is helpful when running salt-cloud in parallel with -P to know which IP address belongs to which host.

What issues does this PR fix or reference?

There is not an issue for this PR.

Previous Behavior

[INFO    ] Address = 10.66.166.111

New Behavior

[INFO    ] Address = 10.66.166.111 | Name = my_test_vm

Merge requirements satisfied?

If this is required for this change, then please let me know.

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@m0duspwnens m0duspwnens requested a review from a team as a code owner August 29, 2024 15:44
@welcome
Copy link

welcome bot commented Aug 29, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to have a changelog entry for the PR. Also are current tests sufficient for this or at least there should be a test which verifies that the correct VM name is reported.

@dwoz dwoz force-pushed the libvirt-create-log-name-with-address branch from 2f2f4f0 to a00db32 Compare February 17, 2025 07:37
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't generally use pipes in our logs. I'd prefer that it (|) is removed here. We'd also need a changelog entry to get this in.

@dmurphy18 dmurphy18 added needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog labels Mar 6, 2025
@dmurphy18
Copy link
Contributor

@m0duspwnens This needs a testcase and a changelog entry. If uninterested in completing this PR, please consider closing it, otherwise if no response within a few weeks, it will be closed due to unresponsive

@dwoz
Copy link
Contributor

dwoz commented Apr 27, 2025

Closing due to lack of follow up.

@dwoz dwoz closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-changelog needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants