Skip to content

Comments

salt/state.py: support retry: True as per docs#67049

Merged
dwoz merged 3 commits intosaltstack:3006.xfrom
tomdoherty:tomdoherty-state-retry-nag
May 28, 2025
Merged

salt/state.py: support retry: True as per docs#67049
dwoz merged 3 commits intosaltstack:3006.xfrom
tomdoherty:tomdoherty-state-retry-nag

Conversation

@tomdoherty
Copy link

@tomdoherty tomdoherty commented Nov 8, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes #67048

Previous Behavior

Below warning displayed when valid option retry: True used

[WARNING ] State is set to retry, but a valid dict for retry configuration was not found.  Using retry defaults

New Behavior

No warning shown. Defaults used as documented

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@tomdoherty tomdoherty requested a review from a team as a code owner November 8, 2024 10:43
@tomdoherty tomdoherty force-pushed the tomdoherty-state-retry-nag branch 4 times, most recently from 0beec24 to 83d22ac Compare November 8, 2024 11:04
twangboy
twangboy previously approved these changes Nov 11, 2024
@twangboy
Copy link
Contributor

Once we get the testing pipeline finished we'll need you to rebase so that we can run the tests.

@tomdoherty
Copy link
Author

Once we get the testing pipeline finished we'll need you to rebase so that we can run the tests.

are we okay to merge this one now? I rebased it

@tomdoherty tomdoherty force-pushed the tomdoherty-state-retry-nag branch from 60ef9fc to b17ff63 Compare March 7, 2025 20:29
@tomdoherty
Copy link
Author

@tomdoherty Need to fix pre-commit errors, please ensure you run pre-commit install in your work area so that pre-commit is run when you execute ``git commit```, this way pre-commit errors can be caught before you push your changes up.

fixed - thank you

@twangboy twangboy force-pushed the tomdoherty-state-retry-nag branch from 56f219a to 52e6f0d Compare May 14, 2025 20:33
@twangboy twangboy requested review from dmurphy18 and removed request for dmurphy18 May 14, 2025 20:34
@dwoz dwoz merged commit f4f986b into saltstack:3006.x May 28, 2025
1372 of 1383 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants