Remove warning when rendering non-SLS files#67067
Open
amendlik wants to merge 3 commits intosaltstack:masterfrom
Open
Remove warning when rendering non-SLS files#67067amendlik wants to merge 3 commits intosaltstack:masterfrom
amendlik wants to merge 3 commits intosaltstack:masterfrom
Conversation
amendlik
force-pushed
the
sls-context
branch
from
0e942f2 to
52e5d26
Compare
twangboy
previously approved these changes
Feb 12, 2025
This function contained a bug that was comparing actual to actual, so every test always passed.
Rather than logging a warning, just populate some of the context variables with appropriate values.
Contributor
|
@amendlik Can you please resolve the conflict? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
My Salt states contain code to render Jinja in YAML files using the
slsutil.rendererfunction, such as:This works fine, but it always produces the error message: "Failed to determine proper template path"
What issues does this PR fix or reference?
None
Previous Behavior
Running
slsutil.rendereron any file other than an SLS file would work, but produce a superfluous warning.New Behavior
Running
slsutil.rendereron non-SLS files succeeds without a warning, and populates the following context variables:tplpathtplfiletpldirMerge requirements satisfied?
Commits signed with GPG?
Yes