Fix gpg.verify with python-gnupg >= 0.5.1#67095
Merged
dwoz merged 3 commits intosaltstack:3007.xfrom Apr 27, 2025
Merged
Conversation
twangboy
requested changes
Feb 11, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Would create a changelog please?
lkubb
force-pushed
the
fix/gpg-verify-trust-levels
branch
from
f1b10c6 to
7a33f93
Compare
lkubb
force-pushed
the
fix/gpg-verify-trust-levels
branch
from
7a33f93 to
559acd1
Compare
dmurphy18
approved these changes
Mar 13, 2025
dwoz
force-pushed
the
fix/gpg-verify-trust-levels
branch
from
6fda58f to
8e22459
Compare
The reported signature validity levels were bumped in vsajip/python-gnupg#205
dwoz
force-pushed
the
fix/gpg-verify-trust-levels
branch
from
8e22459 to
1f892b5
Compare
dwoz
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes signature validity reporting with
python-gnupg >=0.5.1, where the reported levels are off by -1 (changed in vsajip/python-gnupg#205). Thus also fixes a crash with the highest level, which would throw aKeyError.Note: This issue is found in 3006.9 as well, but not as relevant since the pinned version there is
0.4.8. The code has changed a lot between both versions, which is why I opted to submit this for 3007+ only.What issues does this PR fix or reference?
Fixes: #66685
Previous Behavior
New Behavior
Works as expected/reports correct levels
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes