Skip to content

[3006.x] Update for deprecation of hex in pygit2 1.15.0 and above#67105

Merged
dwoz merged 8 commits intosaltstack:3006.xfrom
dmurphy18:fix_67017
Jan 30, 2025
Merged

[3006.x] Update for deprecation of hex in pygit2 1.15.0 and above#67105
dwoz merged 8 commits intosaltstack:3006.xfrom
dmurphy18:fix_67017

Conversation

@dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Dec 18, 2024

What does this PR do?

Updates pygit2 support to allow for removal of support for hex in pygit2 v1.15.0 and above

What issues does thihttps://github.com/saltstack/salt/issues/67017s PR fix or reference?

Fixes #67017

Previous Behavior

Errors and traceback for unsupported hex with pygit2 v1.15.0 and above

File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/gitfs.py", line 2280, in find_file
    return blob, blob.hex, mode
AttributeError: '_pygit2.Blob' object has no attribute 'hex'

New Behavior

No more tracebacks and code works with pygit2 v1.15.0 and above

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 added this to the Sulfur v3006.10 milestone Dec 18, 2024
@dmurphy18 dmurphy18 self-assigned this Dec 18, 2024
@dmurphy18 dmurphy18 requested a review from a team as a code owner December 18, 2024 17:31
@dmurphy18 dmurphy18 changed the title [WIP] [3006.x] Update for deprecation of hex in pygit2 1.15.0 and above [3006.x] Update for deprecation of hex in pygit2 1.15.0 and above Dec 18, 2024
@dmurphy18 dmurphy18 changed the title [3006.x] Update for deprecation of hex in pygit2 1.15.0 and above [WIP][3006.x] Update for deprecation of hex in pygit2 1.15.0 and above Jan 29, 2025
twangboy
twangboy previously approved these changes Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants