[3006.x] systemd_service: remove caching of 'systemctl status' to fix automatic daemon-reload for repeated invocations#67116
Merged
dwoz merged 3 commits intosaltstack:3006.xfrom Mar 8, 2025
Conversation
twangboy
requested changes
Jan 30, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Hey, this looks great. Could we get some tests for this?
hurzhurz
force-pushed
the
fix-systemd_service
branch
from
aabc275 to
a574bff
Compare
Contributor
Author
Well, I was not sure how to do this for this issue, but ok, I gave it a try. |
hurzhurz
force-pushed
the
fix-systemd_service
branch
from
a574bff to
0562d36
Compare
…c daemon-reload for repeated invocations
hurzhurz
force-pushed
the
fix-systemd_service
branch
from
0562d36 to
14029d9
Compare
twangboy
approved these changes
Feb 11, 2025
dmurphy18
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the caching of the
systemctl statusand unit-change-check result in__context__.While the caching could help to avoid a few multiple unnecessary invocations of
systemctl status, it also can cause problems when there are multiple subsequent operations an a service when running a state.apply.See issue for details.
What issues does this PR fix or reference?
Fixes #66864