Skip to content

[3006.x] fix yumpkg for Python <3.8#67152

Merged
dwoz merged 1 commit intosaltstack:3006.xfrom
hurzhurz:fix-yumpkg
Feb 20, 2025
Merged

[3006.x] fix yumpkg for Python <3.8#67152
dwoz merged 1 commit intosaltstack:3006.xfrom
hurzhurz:fix-yumpkg

Conversation

@hurzhurz
Copy link
Contributor

@hurzhurz hurzhurz commented Jan 15, 2025

What does this PR do?

The yumpkg module doesn't not work anymore with Ptyhon versions older than 3.8 because of the usage of the assignment/named expression.
This is a trivial change to fix it.

What issues does this PR fix or reference?

Fixes #67091

@dwoz
Copy link
Contributor

dwoz commented Jan 15, 2025

We do not support python lower than 3.10 in 3006.x.

@hurzhurz
Copy link
Contributor Author

We do not support python lower than 3.10 in 3006.x.

Yes, I understand that it is not officially supported for older python versions.
But it helps a lot that it still works (at least for the most part). Especially for salt-ssh.
And thankfully also the requirements files are kept up to date for python versions down to 3.7.

I guess this tiny change wouldn't harm to keep it working, like it did before 3006.9 ?
And as far as I can tell, this is also the only occurrence of the assignment expression := in 3006 so far.

@dwoz
Copy link
Contributor

dwoz commented Feb 19, 2025

I'm okay with this going into 3006.x. However, let's not merge change this forward. At least, not to master. There are many of these operators in master branch at this point.

@dwoz dwoz merged commit c212603 into saltstack:3006.x Feb 20, 2025
708 checks passed
@lkubb lkubb mentioned this pull request Feb 28, 2025
6 tasks
@hurzhurz hurzhurz deleted the fix-yumpkg branch June 6, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants