Fix refresh of osrelease and related grains on Python 3.10+#67933
Merged
dwoz merged 2 commits intosaltstack:3006.xfrom Apr 25, 2025
Merged
Fix refresh of osrelease and related grains on Python 3.10+#67933dwoz merged 2 commits intosaltstack:3006.xfrom
dwoz merged 2 commits intosaltstack:3006.xfrom
Conversation
twangboy
requested changes
Apr 1, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Could you write a test for this please?
meaksh
force-pushed
the
3006.x-fix-osrelease-grains-refresh
branch
from
a58549b to
c4deb48
Compare
Contributor
Author
Just added a unit test for this |
twangboy
approved these changes
Apr 2, 2025
dwoz
force-pushed
the
3006.x-fix-osrelease-grains-refresh
branch
from
c4deb48 to
02dcf61
Compare
twangboy
force-pushed
the
3006.x-fix-osrelease-grains-refresh
branch
from
02dcf61 to
4e1ec76
Compare
twangboy
force-pushed
the
3006.x-fix-osrelease-grains-refresh
branch
from
4e1ec76 to
4124682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue introduced by dab8ea5 , as the
platformlibrary contains an internal os release cache.This internal cache causes that the
osreleaseand other related grains are not getting refreshed when runningsaltutil.refresh_grains.This PR fixes this issue, by invalidating the internal cache, if existing, at the time of calculating the os related grains.
What issues does this PR fix or reference?
Fixes #67932
Previous Behavior
On Python 3.10+ grains are not refreshed while they get refreshed on Python < 3.10
New Behavior
Consistent behavior across Python versions. Grains get refreshed.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes