[3006.x]Repair Git state comment formatting#67945
Merged
dwoz merged 1 commit intosaltstack:3006.xfrom Apr 25, 2025
Merged
Conversation
b29c760 to
8384325
Compare
8384325 to
adb9495
Compare
adb9495 to
f51c5e3
Compare
Contributor
Author
|
I think the test failures are not related to my patch. |
Contributor
Author
|
Also let me know if you prefer it against 3006.x. |
Contributor
|
Yes please. We usually fix bugs on against the oldest, supported branch where the bug exists. Please rebase this PR on 3006.x. |
f51c5e3 to
6d61128
Compare
Contributor
Author
|
Good to know, thanks, adjusted. |
twangboy
approved these changes
Apr 9, 2025
6d61128 to
f0d32cf
Compare
The _uptodate() function already invokes _format_comments() on the comments passed, avoid duplicate invocations of _format_comments() which caused the joined string result from being joined with dots a second time, effectively placing a dot after every character in the resulting comment output. Also amend the test suite to cover these output conditions. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
f0d32cf to
e76fdf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _uptodate() function already invokes _format_comments() on the comments passed, avoid duplicate invocations of _format_comments() which caused the joined string result from being joined with dots a second time, effectively placing a dot after every character in the resulting comment output.
What does this PR do?
What issues does this PR fix or reference?
#67944
Previous Behavior
New Behavior
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes