[3006.x] Use jscript instead of vscript#67984
Merged
dwoz merged 2 commits intosaltstack:3006.xfrom Apr 27, 2025
Merged
Conversation
twangboy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
VBscript is being deprecated in Windows. It is also blocked by many hardening systems due to security vulnerabilities. In light of this, this PR attempts to use Jscript instead.
What issues does this PR fix or reference?
Fixes #67982
Previous Behavior
The MSI installer attempted to stop the salt-minion service using a VBscript custom action.
New Behavior
The MSI installer now stops the salt-minion service using a Jscript custom action.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes