salt-key -D should error if arguments are given #67903#68003
Merged
twangboy merged 5 commits intosaltstack:3006.xfrom May 6, 2025
Merged
salt-key -D should error if arguments are given #67903#68003twangboy merged 5 commits intosaltstack:3006.xfrom
twangboy merged 5 commits intosaltstack:3006.xfrom
Conversation
dwoz
reviewed
May 1, 2025
dwoz
previously approved these changes
May 2, 2025
twangboy
requested changes
May 5, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Looks like you have some pre-commit/lint failures.
twangboy
approved these changes
May 6, 2025
|
Congratulations on your first PR being merged! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes #67903
Previous Behavior
when -D was used, all the arguments are ignored
New Behavior
if arguments are passed with -D, an error is thrown with instructions to use -d
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No