Use the name instead of the description to identify interfaces#68314
Merged
dwoz merged 4 commits intosaltstack:3006.xfrom Sep 16, 2025
Merged
Use the name instead of the description to identify interfaces#68314dwoz merged 4 commits intosaltstack:3006.xfrom
dwoz merged 4 commits intosaltstack:3006.xfrom
Conversation
twangboy
changed the title
dwoz
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the interface name as shown in "Advanced network settings" to identify network interfaces on Windows.
What issues does this PR fix or reference?
Fixes #58138
Previous Behavior
The interface description was used, which was usually something long and complicated, and couldn't be changed.
New Behavior
No uses the actual name as found in the NetworkInformation.NetworkInterfaces library.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes