Fix batch mode treating error payloads as minion IDs#68672
Open
d3zorg wants to merge 2 commits intosaltstack:masterfrom
Open
Fix batch mode treating error payloads as minion IDs#68672d3zorg wants to merge 2 commits intosaltstack:masterfrom
d3zorg wants to merge 2 commits intosaltstack:masterfrom
Conversation
bdrx312
reviewed
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Batch mode could incorrectly treat transport-level error payloads (e.g. {"error": "...", "failed": True}) as valid minion IDs, leading to spurious "Minion 'error' failed to respond" messages and incorrect batch tracking.
What issues does this PR fix or reference?
Issues: #46876 #48509 #50238 #60724
PRs: #53159 #54725 #54923
Previous Behavior
Running batched commands like
salt -b4 *-minion* test.pingcaused loads of extra errors that are not actual errors and minion payloads misinterpreted:New Behavior
Receiving proper execution list without tons of errors and failing halfway through minion list:
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No