feat(plasma-new-hope): Add invariants support [DONT MERGE]#1983
Draft
neretin-trike wants to merge 3 commits intodevfrom
Draft
feat(plasma-new-hope): Add invariants support [DONT MERGE]#1983neretin-trike wants to merge 3 commits intodevfrom
invariants support [DONT MERGE]#1983neretin-trike wants to merge 3 commits intodevfrom
Conversation
neretin-trike
requested review from
TitanKuzmich,
Yakutoc,
Yeti-or and
shuga2704
as code owners
Contributor
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1983/ |
Contributor
Yeti-or
reviewed
May 20, 2025
Contributor
Yeti-or
left a comment
Yeti-or
left a comment
There was a problem hiding this comment.
В этом пр надо поправить код компонента: 9a29959#r157471608 а смотреть как это будет работать в реальном Button мы не будем ?
| ${({ staticVariants }) => staticVariants}; | ||
| ${({ dynamicVariants }) => dynamicVariants}; | ||
| ${({ intersectionStyles }) => intersectionStyles}; | ||
| ${({ invariants }) => invariants}; |
Contributor
There was a problem hiding this comment.
вопрос такой если я напишу в варицаии disableOpacity отличающийся от того что написано в инварианте, кто победит?
Collaborator
Author
There was a problem hiding this comment.
хм, мне кажется победит инвариант, т.к. он в конце стоит
Collaborator
There was a problem hiding this comment.
А как мы определяем порядок кто должен быть первым и последним?
Collaborator
Author
да, надо будет убрать комменты. Ну я бы пока не хотел менять в реальных компонентах это. Но предлагаю делать точечно, когда появится необходимость при генерации |
Yakutoc
approved these changes
May 27, 2025
neretin-trike
force-pushed
the
neretinaa/add-invariants-support
branch
from
73416bb to
97ab015
Compare
neretin-trike
force-pushed
the
neretinaa/add-invariants-support
branch
from
97ab015 to
85fe43f
Compare
neretin-trike
force-pushed
the
neretinaa/add-invariants-support
branch
from
85fe43f to
d6645ad
Compare
neretin-trike
force-pushed
the
neretinaa/add-invariants-support
branch
from
d6645ad to
b0c9494
Compare
neretin-trike
force-pushed
the
neretinaa/add-invariants-support
branch
from
b0c9494 to
27eb653
Compare
Yakutoc
changed the title
invariants supportinvariants support [DONT MERGE]
neretin-trike
force-pushed
the
neretinaa/add-invariants-support
branch
from
27eb653 to
909acc3
Compare
neretin-trike
force-pushed
the
neretinaa/add-invariants-support
branch
from
909acc3 to
b42df10
Compare
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
force-pushed
the
neretinaa/add-invariants-support
branch
from
b42df10 to
4457f11
Compare
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core
Пример конфига:
What/why changed
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @salutejs/plasma-asdk@0.355.0-canary.1983.19295272379.0 npm install @salutejs/plasma-b2c@1.597.0-canary.1983.19295272379.0 npm install @salutejs/plasma-giga@0.324.0-canary.1983.19295272379.0 npm install @salutejs/plasma-new-hope@0.341.0-canary.1983.19295272379.0 npm install @salutejs/plasma-web@1.599.0-canary.1983.19295272379.0 npm install @salutejs/sdds-bizcom@0.329.0-canary.1983.19295272379.0 npm install @salutejs/sdds-crm@0.328.0-canary.1983.19295272379.0 npm install @salutejs/sdds-cs@0.333.0-canary.1983.19295272379.0 npm install @salutejs/sdds-dfa@0.327.0-canary.1983.19295272379.0 npm install @salutejs/sdds-finai@0.320.0-canary.1983.19295272379.0 npm install @salutejs/sdds-insol@0.324.0-canary.1983.19295272379.0 npm install @salutejs/sdds-netology@0.328.0-canary.1983.19295272379.0 npm install @salutejs/sdds-scan@0.327.0-canary.1983.19295272379.0 npm install @salutejs/sdds-serv@0.328.0-canary.1983.19295272379.0 # or yarn add @salutejs/plasma-asdk@0.355.0-canary.1983.19295272379.0 yarn add @salutejs/plasma-b2c@1.597.0-canary.1983.19295272379.0 yarn add @salutejs/plasma-giga@0.324.0-canary.1983.19295272379.0 yarn add @salutejs/plasma-new-hope@0.341.0-canary.1983.19295272379.0 yarn add @salutejs/plasma-web@1.599.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-bizcom@0.329.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-crm@0.328.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-cs@0.333.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-dfa@0.327.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-finai@0.320.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-insol@0.324.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-netology@0.328.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-scan@0.327.0-canary.1983.19295272379.0 yarn add @salutejs/sdds-serv@0.328.0-canary.1983.19295272379.0