Replace salvo-acme with certon for enhanced ACME support#1339
Open
chrislearn wants to merge 2 commits intomainfrom
Open
Replace salvo-acme with certon for enhanced ACME support#1339chrislearn wants to merge 2 commits intomainfrom
chrislearn wants to merge 2 commits intomainfrom
Conversation
Integrate the certon crate to replace salvo-acme's internal ACME protocol implementation. This removes ~1,200 lines of manual ACME client/JOSE/keypair code and replaces it with a thin adapter layer over certon's production-grade certificate management. New capabilities powered by certon: - Multiple issuers (Let's Encrypt + ZeroSSL + custom CAs) - DNS-01 challenge support - On-demand TLS (certificates at handshake time) - OCSP stapling - Multiple key types (ECDSA P-256/P-384/P-521, RSA, Ed25519) - Pluggable Storage trait for custom backends - Background certificate renewal and OCSP refresh - Rate limiting and distributed solving Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Chrislearn Young <chris@acroidea.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the ACME crate to leverage the
certonlibrary, introducing advanced certificate management features and refactoring the configuration system. The changes modernize the ACME configuration builder, enabling support for multiple issuers, custom solvers, flexible storage, and new challenge types. Additionally, dependencies and features are updated to reflect the transition tocerton.Integration of certon and dependency updates:
certonas a dependency inCargo.toml, and removed legacy dependencies and features related to certificate management. The default feature set is now empty, and feature flags are simplified. [1] [2]certon.Configuration system refactor:
AcmeConfigandAcmeConfigBuilderinconfig.rsto support new fields and options fromcerton, including key type selection, multiple issuers, custom storage, advanced solvers, OCSP stapling, on-demand TLS, and ZeroSSL integration. [1] [2] [3] [4]New builder methods for advanced features:
API and documentation improvements:
Removal of legacy client implementation:
client.rs, as certificate issuance and challenge handling are now managed viacerton.