-
Notifications
You must be signed in to change notification settings - Fork 12
Ogc Api - Styles #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ogc Api - Styles #73
Conversation
src/Common/Standards/OgcApi.Net.Styles/Controllers/MetadataController.cs
Outdated
Show resolved
Hide resolved
src/Common/Standards/OgcApi.Net.Styles/Controllers/StylesController.cs
Outdated
Show resolved
Hide resolved
src/Common/Standards/OgcApi.Net.Styles/Extensions/StylesOpenApiExtension.cs
Outdated
Show resolved
Hide resolved
src/Common/Standards/OgcApi.Net.Styles/Extensions/StylesOpenApiExtension.cs
Outdated
Show resolved
Hide resolved
src/Common/Standards/OgcApi.Net.Styles/Extensions/StylesOpenApiExtension.cs
Outdated
Show resolved
Hide resolved
tests/OgcApi.Net.Styles.Tests/FileSystemStorages/StyleFileSystemStorageTests.cs
Outdated
Show resolved
Hide resolved
tests/OgcApi.Net.Styles.Tests/FileSystemStorages/StyleMetadataFileSystemStorageTests.cs
Outdated
Show resolved
Hide resolved
src/Common/Standards/OgcApi.Net.Styles/Model/Metadata/OgcStyleMetadata.cs
Outdated
Show resolved
Hide resolved
src/Common/Standards/OgcApi.Net.Styles/Storage/FileSystem/StyleFileSystemStorage.cs
Outdated
Show resolved
Hide resolved
alxmcs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would suggest adding summaries to public methods and classes.
danlla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging:
- Add a new markdown file documenting the feature (e.g.,
docs/styles.md) and link it indocs/index.md. - Include the new package in
docs/installation.md. - Add the new standard to the table in
docs/overview.md. - Update
.github/workflows/publish-packages.ymlto build and publish the new package.
kolyanch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new controllers currently do not have any authorization. At least for style modification methods, they are necessary, otherwise the API will be susceptible to attacks.
Resolves #31
This Pull Request adds support for the OGC API - Styles standard.
A library has been written that contains an object model for working with styles and style metadata, as well as controllers that can be integrated into an existing ASP.NET application.
New Endpoints:
GET /{collectionId}/stylesreturns styles associated with the collectionPOST /{collectionId}/stylesadds new style (or new stylesheet of the style) for the collectionPATCH /{collectionId}/stylesupdates default style for the associated collectionGET /{collectionId}/styles/{styleId}returns style info or stylesheet of the style if format is specifiedPUT /{collectionId}/styles/{styleId}replaces existing stylesheet of the styleDELETE /{collectionId}/styles/{styleId}deletes style of the collectionGET /{collectionId}/styles/{styleId}/metadatareturns metadata of the stylePUT /{collectionId}/styles/{styleId}/metadatareplaces metadata of the stylePATCH /{collectionId}/styles/{styleId}/metadataupdates metadata of the styleBy default, styles are stored in the server's file system.
To change the way styles are stored, you need to implement
IStyleStorageandIMetadataStorage.