Skip to content

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 marked this pull request as ready for review November 22, 2024 07:43
@phlogistonjohn
Copy link
Contributor

All-in-all this looks like a great start.

@anoopcs9
Copy link
Collaborator Author

All-in-all this looks like a great start.

Right now there are two triggers:

  • as a cron job
  • when changes are merged in to samba-container repository.

@phlogistonjohn
Copy link
Contributor

Do you want to make a set of test repos on quay.io first to try things out before pushing to the "official" repos? We could use my account if you think that's ok. I have repos set up there already for testing that ought to work just as the quay.io/samba.org ones.

@phlogistonjohn
Copy link
Contributor

To follow up my last comment: I think we don't want the github CI jobs and the centos CI jobs "stepping on" each other. So to make a smooth transition I think we could set up this job but have the final push go somewhere other than the "official" repos for now. WDYT?

@anoopcs9
Copy link
Collaborator Author

Do you want to make a set of test repos on quay.io first to try things out before pushing to the "official" repos? We could use my account if you think that's ok. I have repos set up there already for testing that ought to work just as the quay.io/samba.org ones.

I had some sample pushes here.

To follow up my last comment: I think we don't want the github CI jobs and the centos CI jobs "stepping on" each other. So to make a smooth transition I think we could set up this job but have the final push go somewhere other than the "official" repos for now. WDYT?

Make sense.

I have another question. How do we decide the image(arm64/amd64 variant) to be tagged as latest and nightly? Right now with these jobs running whichever completes the final push gets the latest and nightly tag.

@phlogistonjohn
Copy link
Contributor

I have another question. How do we decide the image(arm64/amd64 variant) to be tagged as latest and nightly? Right now with these jobs running whichever completes the final push gets the latest and nightly tag.

Short term: the amd64 images only should get the short* tags - it matches what we have been doing

Long term: we need to switch to using manifests (aka image indexes) for the short tags. I have some WIP patches to the builder script that can do this, but it's all a messy jumble that I need to sort out and make a PR.

  • In the code there are varying levels of "unqualified" tags.

@anoopcs9
Copy link
Collaborator Author

I have another question. How do we decide the image(arm64/amd64 variant) to be tagged as latest and nightly? Right now with these jobs running whichever completes the final push gets the latest and nightly tag.

Short term: the amd64 images only should get the short* tags - it matches what we have been doing

I've updated the logic accordingly, thanks.

Copy link

dpulls bot commented Nov 27, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good enough start for now, so we can see it in actual automation.
There's some stuff I want to do with build-image before switching to this as the official method for building images but I think I don't want to wait for that to see this in action.

@phlogistonjohn
Copy link
Contributor

After we merge this can we:

  1. Add links and documentation to samba-container repo pointing here
  2. and at the jenkins status (I always forget where to look)

@anoopcs9 anoopcs9 force-pushed the add-container-jobs branch from 32957d1 to 468e647 Compare January 7, 2025 07:37
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Jan 8, 2025

Taking these in as initial configuration which can be extended later. Following are the exclusions from the maximum possible build matrix:

  • As we do not have ceph RPMs built from development branch for Fedora platform we refrain from creating any job consuming those RPMs.
  • ctdb package by default gets installed from 'Resilient Storage' repository on CentOS but it is not available for ARM64 architecture. Thus we exclude the job to build container using CentOS provided samba/ctdb RPMs for ARM64 architecture.

@anoopcs9 anoopcs9 merged commit 397c9d3 into samba-in-kubernetes:main Jan 8, 2025
2 checks passed
@anoopcs9 anoopcs9 deleted the add-container-jobs branch January 8, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants