-
Notifications
You must be signed in to change notification settings - Fork 4
Add jobs to build+push samba containers #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jobs to build+push samba containers #73
Conversation
76abd86
to
99fbd17
Compare
All-in-all this looks like a great start. |
Right now there are two triggers:
|
Do you want to make a set of test repos on quay.io first to try things out before pushing to the "official" repos? We could use my account if you think that's ok. I have repos set up there already for testing that ought to work just as the |
To follow up my last comment: I think we don't want the github CI jobs and the centos CI jobs "stepping on" each other. So to make a smooth transition I think we could set up this job but have the final push go somewhere other than the "official" repos for now. WDYT? |
I had some sample pushes here.
Make sense. I have another question. How do we decide the image(arm64/amd64 variant) to be tagged as |
Short term: the amd64 images only should get the short* tags - it matches what we have been doing Long term: we need to switch to using manifests (aka image indexes) for the short tags. I have some WIP patches to the builder script that can do this, but it's all a messy jumble that I need to sort out and make a PR.
|
99fbd17
to
17396bd
Compare
I've updated the logic accordingly, thanks. |
🎉 All dependencies have been resolved ! |
jobs/scripts/nightly-samba-containers/nightly-samba-containers.sh
Outdated
Show resolved
Hide resolved
17396bd
to
daeec05
Compare
daeec05
to
32957d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good enough start for now, so we can see it in actual automation.
There's some stuff I want to do with build-image
before switching to this as the official method for building images but I think I don't want to wait for that to see this in action.
After we merge this can we:
|
32957d1
to
468e647
Compare
Taking these in as initial configuration which can be extended later. Following are the exclusions from the maximum possible build matrix:
|
depends on samba-in-kubernetes/samba-container#183