Skip to content

Conversation

phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Jun 9, 2025

Update the install-sambacc-common.sh script so that setting
up and using COPR repos is eaiser.
Make some small cleanups and updates to use the new sambacc-extras-deps
repository.

@phlogistonjohn phlogistonjohn force-pushed the jjm-more-copr branch 2 times, most recently from c4bdd4a to 01883f4 Compare June 9, 2025 20:07
obnoxxx
obnoxxx previously approved these changes Jun 10, 2025
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look clean and build jobs in the CI passed.

LGTM.

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall logic seems a bit convoluted and hard to digest on first pass. Isn't it possible to simplify enable_copr() with just the looping over the list of copr repositories with a special case for CentOS Stream 9?

Update the install-sambacc-common.sh script so that setting
up and using COPR repos is eaiser.
Make some small cleanups and updates to use the new sambacc-extras-deps
repository.

Signed-off-by: John Mulligan <[email protected]>
@phlogistonjohn
Copy link
Collaborator Author

Updated. Any clearer?

@mergify mergify bot dismissed obnoxxx’s stale review June 11, 2025 13:02

Pull request has been modified.

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Any clearer?

lgtm.

@phlogistonjohn phlogistonjohn merged commit 57eee95 into samba-in-kubernetes:master Jun 11, 2025
39 checks passed
Shwetha-Acharya

This comment was marked as outdated.

@phlogistonjohn phlogistonjohn deleted the jjm-more-copr branch June 12, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants