-
Notifications
You must be signed in to change notification settings - Fork 20
images: automate enabling copr repos when installing sambacc #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images: automate enabling copr repos when installing sambacc #205
Conversation
e92b5b2
to
51dfc22
Compare
c4bdd4a
to
01883f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look clean and build jobs in the CI passed.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall logic seems a bit convoluted and hard to digest on first pass. Isn't it possible to simplify enable_copr() with just the looping over the list of copr repositories with a special case for CentOS Stream 9?
Update the install-sambacc-common.sh script so that setting up and using COPR repos is eaiser. Make some small cleanups and updates to use the new sambacc-extras-deps repository. Signed-off-by: John Mulligan <[email protected]>
01883f4
to
cc2e370
Compare
Updated. Any clearer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Any clearer?
lgtm.
Update the install-sambacc-common.sh script so that setting
up and using COPR repos is eaiser.
Make some small cleanups and updates to use the new sambacc-extras-deps
repository.