Skip to content

images/server: Few improvements to install-packages.sh #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

images/server: Few improvements to install-packages.sh #206

merged 1 commit into from
Jun 12, 2025

Conversation

anoopcs9
Copy link
Collaborator

  • Add a default case to define $package_selection.
  • Enable EPEL irrespective of $install_packages_from.
  • Update ceph version to squid for default centos.

@anoopcs9
images/server: Few improvements to install-packages.sh
37dcd00 
- Add a default case to define $package_selection.
- Enable EPEL irrespective of $install_packages_from.
- Update ceph version to squid for default centos.

Signed-off-by: Anoop C S <[email protected]>
@anoopcs9
Copy link
Collaborator Author

As intended, the following changes are visible from CI runs for build-server (default, centos, amd64):

#8 0.134 + dnf install --setopt=install_weak_deps=False -y epel-release
#8 1.641 CentOS Stream 9 - BaseOS                        6.6 MB/s | 8.7 MB     00:01    
#8 3.724 CentOS Stream 9 - AppStream                      22 MB/s |  24 MB     00:01    
#8 8.863 CentOS Stream 9 - Extras packages                17 kB/s |  19 kB     00:01    
#8 9.631 Dependencies resolved.
#8 9.632 ================================================================================
#8 9.632  Package             Architecture  Version           Repository            Size
#8 9.632 ================================================================================
#8 9.632 Installing:
#8 9.632  epel-release        noarch        9-7.el9           extras-common         19 k
#8 9.632 
#8 9.632 Transaction Summary
#8 9.632 ================================================================================
#8 9.632 Install  1 Package
. . .
#8 10.31 + dnf install --setopt=install_weak_deps=False -y centos-release-ceph-squid
#8 11.25 Extra Packages for Enterprise Linux 9 - x86_64   30 MB/s |  20 MB     00:00    
#8 17.40 Extra Packages for Enterprise Linux 9 openh264  5.7 kB/s | 2.5 kB     00:00    
#8 18.75 Dependencies resolved.
#8 18.75 ================================================================================
#8 18.75  Package                         Arch     Version         Repository       Size
#8 18.75 ================================================================================
#8 18.75 Installing:
#8 18.75  centos-release-ceph-squid       noarch   1.0-1.el9s      extras-common   7.3 k
#8 18.75 Installing dependencies:
#8 18.75  centos-release-storage-common   noarch   2-5.el9s        extras-common   8.3 k
#8 18.75 
#8 18.75 Transaction Summary
#8 18.75 ================================================================================
#8 18.75 Install  2 Packages
. . .
#11 19.26 + dnf install -y python3-sambacc
#11 20.12 Copr repo for sambacc owned by phlogistonjohn    14 kB/s | 9.7 kB     00:00    
#11 20.81 Copr repo for sambacc-extras-deps owned by phlo  61 kB/s |  42 kB     00:00    
#11 22.40 Dependencies resolved.
#11 22.40 ===============================================================================================================================
#11 22.40  Package                 Arch    Version               Repository                                                          Size
#11 22.40 ===============================================================================================================================
#11 22.40 Installing:
#11 22.40  python3-sambacc         noarch  0.7~57.g961d1c1-1.el9 copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc              170 k
#11 22.40 Installing dependencies:
#11 22.40  abseil-cpp              x86_64  20211102.0-4.el9      epel                                                               551 k
#11 22.40  c-ares                  x86_64  1.19.1-2.el9          baseos                                                             111 k
#11 22.40  grpc-data               noarch  1.48.4-44.el9         copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc-extras-deps   21 k
#11 22.40  libibverbs              x86_64  54.0-1.el9            baseos                                                             451 k
#11 22.40  libnl3                  x86_64  3.11.0-1.el9          baseos                                                             363 k
#11 22.40  librados2               x86_64  2:19.2.2-1.el9s       centos-ceph-squid                                                  3.6 M
#11 22.40  librdmacm               x86_64  54.0-1.el9            baseos                                                              71 k
#11 22.40  lttng-ust               x86_64  2.12.0-6.el9          appstream                                                          292 k
#11 22.40  numactl-libs            x86_64  2.0.19-1.el9          baseos                                                              32 k
#11 22.40  protobuf                x86_64  3.19.6-11.el9         copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc-extras-deps  987 k
#11 22.40  python3-grpcio          x86_64  1.48.4-44.el9         copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc-extras-deps  2.1 M
#11 22.40  python3-protobuf        x86_64  3.19.6-11.el9         copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc-extras-deps  329 k
#11 22.40  python3-pyyaml          x86_64  5.4.1-6.el9           baseos                                                             205 k
#11 22.40  python3-rados           x86_64  2:19.2.2-1.el9s       centos-ceph-squid                                                  323 k
#11 22.40  python3-tomli           noarch  2.0.1-5.el9           appstream                                                           33 k
#11 22.40  re2                     x86_64  1:20211101-20.el9     epel                                                               191 k
#11 22.40  thrift                  x86_64  0.15.0-4.el9          epel                                                               1.6 M
#11 22.40  userspace-rcu           x86_64  0.12.1-6.el9          baseos                                                             110 k
#11 22.40 Installing weak dependencies:
#11 22.40  python3-sambacc+grpc    noarch  0.7~57.g961d1c1-1.el9 copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc              8.5 k
#11 22.40  python3-sambacc+rados   noarch  0.7~57.g961d1c1-1.el9 copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc              8.4 k
#11 22.40  python3-sambacc+toml    noarch  0.7~57.g961d1c1-1.el9 copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc              8.4 k
#11 22.40  python3-sambacc+yaml    noarch  0.7~57.g961d1c1-1.el9 copr:copr.fedorainfracloud.org:phlogistonjohn:sambacc              8.4 k
#11 22.40 
#11 22.40 Transaction Summary
#11 22.40 ===============================================================================================================================
#11 22.40 Install  23 Packages

phlogistonjohn
phlogistonjohn approved these changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

Shwetha-Acharya
Shwetha-Acharya approved these changes Jun 12, 2025
View reviewed changes
Copy link

@Shwetha-Acharya Shwetha-Acharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoopcs9 anoopcs9 merged commit 7a7a9ad into samba-in-kubernetes:master Jun 12, 2025
39 checks passed
@anoopcs9 anoopcs9 deleted the install-script-improvements branch June 12, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhernandez xhernandez xhernandez approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

+1 more reviewer

@Shwetha-Acharya Shwetha-Acharya Shwetha-Acharya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

priority-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anoopcs9 @xhernandez @Shwetha-Acharya @phlogistonjohn