Skip to content

Add ceph20 package source corresponding to ceph tentacle #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2025
Merged

Add ceph20 package source corresponding to ceph tentacle #209

merged 3 commits into from
Aug 12, 2025

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Jul 10, 2025 •
edited
Loading

  • Create and enable a new ceph20 package source
  • Include libcephfs-proxy for stable package selection on CentOS
  • Update build-image script with new ceph20 package source

fixes #204

depends on #212 #215

@anoopcs9
Copy link
Collaborator Author

CI failures are expected until ceph tentacle builds are available for Fedora and CentOS. Only jobs with devbuilds package source are expected to successfully complete for now.

@anoopcs9 anoopcs9 mentioned this pull request Jul 10, 2025
Closed
phlogistonjohn
phlogistonjohn reviewed Jul 10, 2025
View reviewed changes
@anoopcs9 anoopcs9 force-pushed the ceph20-pkg-src branch 4 times, most recently from f421bf2 to 065d2a7 Compare July 31, 2025 10:28
@anoopcs9 anoopcs9 marked this pull request as ready for review July 31, 2025 15:42
@anoopcs9 anoopcs9 requested a review from phlogistonjohn July 31, 2025 15:42
phlogistonjohn
phlogistonjohn reviewed Jul 31, 2025
View reviewed changes
@anoopcs9 anoopcs9 force-pushed the ceph20-pkg-src branch 2 times, most recently from 3340e2d to 0085c94 Compare August 1, 2025 13:57
@dpulls dpulls
Copy link

dpulls bot commented Aug 1, 2025

🎉 All dependencies have been resolved !

@mergify Mergify
Copy link

mergify bot commented Aug 1, 2025

This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch.

phlogistonjohn
phlogistonjohn reviewed Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good. Please rebase when you have a moment and I'll give a proper review when it's in a more mergable state. Thanks!

@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented Aug 5, 2025

rebase

☑️ Nothing to do, the required conditions are not met

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

phlogistonjohn
phlogistonjohn previously approved these changes Aug 5, 2025
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@phlogistonjohn
Copy link
Collaborator

Deadline - I'm going to merge this on Wednesday (2025-08-13) if no additional reviews are provided.

Shwetha-Acharya
Shwetha-Acharya approved these changes Aug 12, 2025
View reviewed changes
Copy link

@Shwetha-Acharya Shwetha-Acharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify bot dismissed phlogistonjohn’s stale review August 12, 2025 06:05

Pull request has been modified.

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Aug 12, 2025 •
edited
Loading

Deadline - I'm going to merge this on Wednesday (2025-08-13) if no additional reviews are provided.

Sorry for the new update. I noticed a small nit (see diff) but unfortunately ceph chacra repo urls seems to have some issues 🫤 causing CI to fail.

Edit: Today's scheduled CI run also had similar failures.

@dpulls dpulls
Copy link

dpulls bot commented Aug 12, 2025

🎉 All dependencies have been resolved !

@anoopcs9
Copy link
Collaborator Author

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented Aug 12, 2025

rebase

✅ Branch has been successfully rebased

spuiuk
spuiuk previously approved these changes Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

phlogistonjohn
phlogistonjohn previously approved these changes Aug 12, 2025
View reviewed changes
mergify bot added a commit that referenced this pull request Aug 12, 2025
@mergify
Merge of #209
f759e65
@mergify mergify bot mentioned this pull request Aug 12, 2025
Closed
@phlogistonjohn
Copy link
Collaborator

mergify, I do not understand you.

@mergify Mergify
Copy link

mergify bot commented Aug 12, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #216.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Aug 12, 2025
@mergify
Merge of #209
f208a89
@mergify mergify bot mentioned this pull request Aug 12, 2025
Closed
@mergify Mergify
Copy link

mergify bot commented Aug 12, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #217.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Aug 12, 2025
@mergify
Merge of #209
e2111a2
@mergify mergify bot mentioned this pull request Aug 12, 2025
Closed
@mergify Mergify
Copy link

mergify bot commented Aug 12, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #218.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Aug 12, 2025
@mergify
Merge of #209
062470e
@mergify mergify bot mentioned this pull request Aug 12, 2025
Closed
@anoopcs9
images/server: Add 'ceph20' package source for ceph tentacle
42cf1ea 
With tentacle we have libcephfs-proxy automatically available from
standard repositories.

Signed-off-by: Anoop C S <[email protected]>
@anoopcs9
hack/build-image: Define 'ceph20' package source
1614344 
Signed-off-by: Anoop C S <[email protected]>
@anoopcs9
workflows: Enable samba-server builds for ceph20 source
43210c6 
Signed-off-by: Anoop C S <[email protected]>
@mergify Mergify
Copy link

mergify bot commented Aug 12, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #209 has been manually updated.

You can check the last failing draft PR here: #219.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify mergify bot dismissed stale reviews from spuiuk and phlogistonjohn August 12, 2025 15:56

Pull request has been modified.

@phlogistonjohn phlogistonjohn merged commit 219ec74 into samba-in-kubernetes:master Aug 12, 2025
76 of 82 checks passed
@anoopcs9 anoopcs9 deleted the ceph20-pkg-src branch August 12, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@spuiuk spuiuk spuiuk left review comments

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

@avanthakkar avanthakkar Awaiting requested review from avanthakkar

+1 more reviewer

@Shwetha-Acharya Shwetha-Acharya Shwetha-Acharya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a stable ceph oriented build target

4 participants

@anoopcs9 @phlogistonjohn @spuiuk @Shwetha-Acharya