-
Notifications
You must be signed in to change notification settings - Fork 20
hack: support even more customization #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 13 commits into
samba-in-kubernetes:master
from
phlogistonjohn:jjm-custom-custom-2
Aug 5, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
70635bc
gitignore: generalize the .build files ignore rule
phlogistonjohn 1ecfc17
images/server: allow --ceph-from-custom=1
phlogistonjohn 9eda4ed
images/server: add build argument CEPH_FROM_CUSTOM
phlogistonjohn beb31e5
hack: reformat comment
phlogistonjohn 6f4cbc4
hack: use constants already defined in the code
phlogistonjohn 0c6a5f0
hack: don't call same function many times
phlogistonjohn bea1552
hack: remove unnecessary uses of lambda
phlogistonjohn d77e8b9
hack: support custom container build config files
phlogistonjohn 8333d2f
hack: split some functions so that the original call is less sprawling
phlogistonjohn 5f7ac47
hack: fix formatting
phlogistonjohn 1f2662e
hack: allow customizing the containerfile name
phlogistonjohn 6f39dfe
hack: add support for customizing sambacc
phlogistonjohn c196db2
examples: example custom config file
phlogistonjohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,4 @@ | ||
*~ | ||
.build.server | ||
.build.opensuse-server | ||
.build.ad-server | ||
.build.opensuse-ad-server | ||
.build.client | ||
.build.opensuse-client | ||
.build.toolbox | ||
.build.opensuse-toolbox | ||
.build.nightly.server | ||
.build.nightly.ad-server | ||
.build.* | ||
.common | ||
.bin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Example config file for passing to hack/build-image `-C` option. | ||
# Use this as a template to create customized images using work | ||
# in progress branches of sambacc or custom builds of samba/ceph/etc | ||
# packages. | ||
|
||
[image] | ||
custom_repos = | ||
http://my.rpmserver.example.org/foo/bar/samba/config.repo | ||
http://my.rpmserver.exampel.org/foo/bar/ceph/config.repo | ||
package_selection = forcedevbuilds | ||
ceph_from_custom = 1 | ||
extra_arguments = --cache-ttl=1h | ||
|
||
[sambacc] | ||
#base_image = sambacc:ci | ||
sambacc_repo = https://github.com/samba-in-kubernetes/sambacc | ||
sambacc_ver = my-branch | ||
distname = latest | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.