images/server: Remove explicit installation of dependencies #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio rebase |
These packages[1] are automatically pulled in with python3-sambacc
extras which gets built by default and available for installation
as weak dependencies. If we know that these packages[1] exists and
available, then we should be good here to assume that they are pulled
in during the installation of corresponding python3-sambacc extras.
$ rpm -q --requires \
python3-sambacc+toml-0.8~1.g52a3e0101-1.el9.noarch.rpm | grep tomli
python3.9dist(tomli)
$ rpm -q --requires \
python3-sambacc+yaml-0.8~1.g52a3e0101-1.el9.noarch.rpm | grep pyyaml
python3.9dist(pyyaml) >= 5.4
$ rpm -q --requires \
python3-sambacc+rados-0.8~1.g52a3e0101-1.el9.noarch.rpm | grep rados
python3.9dist(rados)
[1] python3-pyyaml, python3-tomli and python3-rados
Signed-off-by: Anoop C S <[email protected]>
✅ Branch has been successfully rebased |
anoopcs9
force-pushed
the
rm-explicit-install
branch
from
cc9be63 to
37f1eb5
Compare
phlogistonjohn
approved these changes
Oct 2, 2025
xhernandez
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages are automatically pulled in with
python3-sambaccextras which gets built by default and available for installation as weak dependencies. If we know that these packages exists and available, then we shoud be good here to assume that they are pulled in during the installation of correspondingpython3-sambaccextras.