Skip to content

Conversation

phlogistonjohn
Copy link
Collaborator

Fedora 41 has been out for some weeks now. Update the test matrix to remove Fedora 39 and use fedora 41.

@phlogistonjohn
Copy link
Collaborator Author

Reminder: this will probably need manual merging as the test names are changing. I'll do it once I have sufficient reviews.

I wonder if I should rename the fedora test jobs something like fedora-previous and fedora-current or something to avoid this (small bit of) churn? Any opinions?

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if I should rename the fedora test jobs something like fedora-previous and fedora-current or something to avoid this (small bit of) churn? Any opinions?

Well, we can't get rid of changes unless we do something as follows:

latest=$(curl -s -L https://fedoraproject.org/releases.json | jq -r '[.[].version | select("^[0-9]+$")] | max')

previous=$(( $latest - 1 ))

And of course I prefer "latest" over "current".

Would you like to go for it with the current PR?

@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

Fedora 41 has been out for some weeks now. Update the test matrix to
remove Fedora 39 and use fedora 41.

Signed-off-by: John Mulligan <[email protected]>
Copy link

mergify bot commented Jan 8, 2025

rebase

✅ Branch has been successfully rebased

Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlogistonjohn
Copy link
Collaborator Author

Would you like to go for it with the current PR?

No, I would like to make that change in a different pr. All this slipped off my radar so I would rather fix the immediate issue and then do future proofing later.

@phlogistonjohn phlogistonjohn merged commit d92113a into samba-in-kubernetes:master Jan 8, 2025
8 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-fc41 branch January 8, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants