Skip to content

commands: fix a mypy failure in the ctdb commands module #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

commands: fix a mypy failure in the ctdb commands module #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions sambacc/commands/ctdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,17 +271,19 @@ def _lookup_hostname(hostname: str) -> str:
)
ipv6_address = None

for entry in addrinfo:
family, _, _, _, sockaddr = entry
ip_address = sockaddr[0]

if ip_address.startswith("127.") or ip_address == "::1":
continue

for family, _, _, _, sockaddr in addrinfo:
if family == socket.AF_INET:
ip_address = sockaddr[0]
assert isinstance(ip_address, str)
if ip_address.startswith("127."):
continue
return ip_address

if family == socket.AF_INET6 and ipv6_address is None:
ip_address = sockaddr[0]
assert isinstance(ip_address, str)
if ip_address == "::1":
continue
ipv6_address = ip_address

if ipv6_address:
Expand Down
Loading