Skip to content

Conversation

@phlogistonjohn
Copy link
Collaborator

Allow a vendor dist suffix field in the spec file.

It can be passed to the build script with the VENDOR_DIST_SUFFIX env var
set to a value. Then it will pass that along to the rpm build as the
vendordist value to be suffixed to the release ver.

@phlogistonjohn
Copy link
Collaborator Author

The test failures are due to a change in flake8 ... there's a fix for that in #150

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

If the shell script is run with the VENDOR_DIST_SUFFIX env var
set to a value, it will pass that along to the rpm build as the
vendordist value to be suffixed to the release ver.

Signed-off-by: John Mulligan <[email protected]>
@mergify
Copy link

mergify bot commented Apr 24, 2025

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the jjm-vendor-suffix branch from 2bb2a9f to 1c4cc0e Compare April 24, 2025 12:15
@anoopcs9 anoopcs9 requested a review from spuiuk April 25, 2025 07:19
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 76646e9 into samba-in-kubernetes:master Apr 25, 2025
9 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-vendor-suffix branch August 20, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants