commands: a variety of small cli handling cleanups #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
force-pushed
the
jjm-cli-nibbles
branch
from
4967dcd to
961cc68
Compare
anoopcs9
reviewed
May 15, 2025
Not directly as I added the new method to handle the functions that are decorated by |
xhernandez
approved these changes
May 16, 2025
|
@Mergifyio rebase |
When a docstring is present the ellipsis to create a function body is not necessary. Remove them in cli.py Signed-off-by: John Mulligan <[email protected]>
The cli.ceph_id is a copy of the main._ceph_id function moved to cli.py as it is a option parsing type that could be reused elsewhere in the future. Signed-off-by: John Mulligan <[email protected]>
The samba-container command that is based on main.py shares a bunch of functions with dcmain.py the file backing the samba-dc-container command. Move a bunch of that common functionality to common.py a new file for these common things. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Avoid importing with noqa comments when importing a file just for the commands it provides. Add a function to "include" (aka import for commands) to the command builder type. Signed-off-by: John Mulligan <[email protected]>
Use the new include method(s) and avoid top-level imports that just exist to pull in decorated command functions. Signed-off-by: John Mulligan <[email protected]>
Now that the main samba-container entrypoint is cleaned up, allow the dc script entry point to be a bit more like the regular commmands when set up. Signed-off-by: John Mulligan <[email protected]>
Split the job of the formatting testenv that was previously running both flake8 and black. Let formatting focus on code formatting only (using black) and add a new testenv "flake8" for running said tool. This avoids overloading the testenvs and allows for more flexibility like running these envs with tox's --parallel option. Signed-off-by: John Mulligan <[email protected]>
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-cli-nibbles
branch
from
961cc68 to
9c5558e
Compare
|
mergify seems to be to be ingoring Xavi's review because he didn't have write perms on this repo before today. I need one more review, or I can just force it by putting on the label... I may wait a little while... but not too long :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for some future work, clean up how we construct the sambacc command line tools: samba-container and samba-dc-container. Make common stuff common, add docstrings and make things less special.