Skip to content

Conversation

@anoopcs9
Copy link
Collaborator

Mergify rules doesn't check the status of pull requests before adding the "priority-review" label. In addition to the existing rules it only makes sense to add the label if the pull request is in open state.

Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds reasonable and I think it is a good idea.

looks good in general, but I doubt that draftis the same as openhere.

- "updated-at<15 days ago"
- "-draft"
- "-closed"
- "-merged"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this leaves only draft.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention here is to NOT consider closed and merged PRs in addition to the existing condition to EXCLUDE draft PRs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obnoxxx Can you please explain if there is any real concern here?

@anoopcs9 anoopcs9 requested a review from obnoxxx May 27, 2025 13:53
@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented May 30, 2025

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the mergify-restrict-label branch from e2198bc to 0f2fe58 Compare May 30, 2025 17:17
@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

Mergify rules doesn't check the status of pull requests before adding
the "priority-review" label. In addition to the existing rules it only
makes sense to add the label if the pull request is in open state.

Signed-off-by: Anoop C S <[email protected]>
@mergify
Copy link

mergify bot commented May 30, 2025

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the mergify-restrict-label branch from 0f2fe58 to 1117089 Compare May 30, 2025 17:19
@phlogistonjohn phlogistonjohn merged commit c5e2b4c into samba-in-kubernetes:master May 30, 2025
9 checks passed
@anoopcs9 anoopcs9 deleted the mergify-restrict-label branch June 30, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants