-
Notifications
You must be signed in to change notification settings - Fork 17
mergify: Restrict the addition of "priority-review" label #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mergify: Restrict the addition of "priority-review" label #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds reasonable and I think it is a good idea.
looks good in general, but I doubt that draftis the same as openhere.
| - "updated-at<15 days ago" | ||
| - "-draft" | ||
| - "-closed" | ||
| - "-merged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this leaves only draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention here is to NOT consider closed and merged PRs in addition to the existing condition to EXCLUDE draft PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@obnoxxx Can you please explain if there is any real concern here?
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
e2198bc to
0f2fe58
Compare
|
@Mergifyio rebase |
Mergify rules doesn't check the status of pull requests before adding the "priority-review" label. In addition to the existing rules it only makes sense to add the label if the pull request is in open state. Signed-off-by: Anoop C S <[email protected]>
✅ Branch has been successfully rebased |
0f2fe58 to
1117089
Compare
Mergify rules doesn't check the status of pull requests before adding the "priority-review" label. In addition to the existing rules it only makes sense to add the label if the pull request is in open state.