Skip to content

Conversation

@anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented May 29, 2025

Instead of updating the versions during each fedora release we could automatically filter out the recent versions from publically available json data for fedora releases. We also take this opportunity to rename the corresponding test jobs to avoid updating the mergify configuration for every fedora release.

fixes #145

@anoopcs9 anoopcs9 force-pushed the workflows-detect-fedora-versions branch 6 times, most recently from 380927f to 46e7061 Compare May 29, 2025 11:31
@anoopcs9 anoopcs9 marked this pull request as ready for review May 29, 2025 11:47
@anoopcs9
Copy link
Collaborator Author

But we still need to update Mergify configuration 😐 . Can we get rid of that too?

@phlogistonjohn
Copy link
Collaborator

Instead of labeling the jobs with the version number call them fedora-latest and fedora-previous (or something)?
Then we do not need to keep updating that file.

@phlogistonjohn
Copy link
Collaborator

Or are you suggesting to dump mergify entirely? I would not be opposed but I want an equivalent workflow (via actions?) and I don't know if we want to take that on now.

@anoopcs9
Copy link
Collaborator Author

Instead of labeling the jobs with the version number call them fedora-latest and fedora-previous (or something)? Then we do not need to keep updating that file.

Perfect, thanks.

Or are you suggesting to dump mergify entirely? I would not be opposed but I want an equivalent workflow (via actions?) and I don't know if we want to take that on now.

Nah..

@anoopcs9 anoopcs9 force-pushed the workflows-detect-fedora-versions branch from d668f6e to 4ccc409 Compare May 29, 2025 14:05
@anoopcs9 anoopcs9 requested a review from phlogistonjohn May 29, 2025 14:13
@phlogistonjohn
Copy link
Collaborator

I will merge this later today, but I will wait a couple of hours for any additional feedback, but this needs to be merged manually anyway because of the changes to the mergify config.

@anoopcs9
Copy link
Collaborator Author

@Mergifyio rebase

anoopcs9 added 2 commits May 30, 2025 07:29
Instead of updating the versions during each fedora release we could
automatically filter out the recent versions from publically available
json data for fedora releases. In addition to that we rename fedora
test jobs to symbolically represent the supported releases of fedora.
This is done in an attempt to reduce the need for updating mergify
configuration during each fedora release.

Signed-off-by: Anoop C S <[email protected]>
Use the newly introduced symbolic names, fedora-latest and
fedora-previous, replacing the hard coded release version
specific test jobs to avoid updating the configuration for
each fedora release.

Signed-off-by: Anoop C S <[email protected]>
@mergify
Copy link

mergify bot commented May 30, 2025

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the workflows-detect-fedora-versions branch from 4ccc409 to 89da51c Compare May 30, 2025 07:29
@phlogistonjohn phlogistonjohn merged commit 886bc7d into samba-in-kubernetes:master May 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

automate running on latest fedora version in ci matrix

3 participants