samba_cmds: Do not add --debuglevel for wbinfo and ctdb commands
#159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
phlogistonjohn
requested changes
Jun 4, 2025
There was a problem hiding this comment.
Thanks for looking into this. I started looking into it back in December and then it slipped off my radar.
The general gist looks ok, but I would prefer you use the existing execvp wrapper function unless it doesn't work for some reason - and then either justify why or enhance the existing wrapper.
This is done in preparation to accept objects of CommandArgs class which is the parent class for SambaCommand. Signed-off-by: Anoop C S <[email protected]>
When '--samba-debug-level' (or SAMBA_DEBUG_LEVEL env var) is specified with samba-container command it adds '--debuglevel' to the underlying command which is not valid for wbinfo resulting in "Invalid option". Instead change its internal type to parent class CommandArgs where we get to run without debug arguments. Signed-off-by: Anoop C S <[email protected]>
When '--samba-debug-level' (or SAMBA_DEBUG_LEVEL env var) is specified with samba-container command it adds '--debuglevel' to the underlying command which is not valid for ctdb resulting in "Invalid option". Instead change its internal type to parent class CommandArgs where we get to run without debug arguments. Signed-off-by: Anoop C S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wbinfo and ctdb commands do not accept
--debugleveloptional argument. Make sure that we execute those commands without--debuglevelin the presence of--samba-debug-leveloptional argument to samba-container command or its equivalent withSAMBA_DEBUG_LEVELenvironment variable.fixes #141