ctdb: add option to change ctdb port #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mulligan <[email protected]>
The samba wiki documents the way to have CTDB use a different port is to edit /etc/services. While this seems a bit strange we are running in a container so we won't side-effect anything else. See: https://wiki.samba.org/index.php/Advanced_CTDB_configuration#CTDB_port Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-ctdb-port
branch
from
7632310 to
c68e41f
Compare
|
Basic manual testing on a ceph cluster passed. |
phlogistonjohn
requested review from
Shwetha-Acharya,
anoopcs9,
avanthakkar and
spuiuk
spuiuk
approved these changes
Jun 12, 2025
avanthakkar
approved these changes
Jun 13, 2025
anoopcs9
reviewed
Jun 13, 2025
There was a problem hiding this comment.
Just one thing I read in wiki
"Note: All nodes in the cluster must use the same port.", so was wondering if we need to explicitly check this condition?
Be it any configuration file (/etc/services in this case) this is implicitly taken care of as each node is acting based on the same instance config passed down from higher levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mechanism for changing the CTDB port.