keybridge: some fixes and error handling improvements #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an annoying behavior in the python varlink lib. It's described in the comment. Work around it by proactively removing the socket file before the server starts. Signed-off-by: John Mulligan <[email protected]>
To be more consistent across all the objects and errors, rename "entry" to "name". It was always the name. When the API expects a whole entry object we should use "entry". "name" is a string. Signed-off-by: John Mulligan <[email protected]>
Fix an exception raised when trying to override the peer verification settings on the CLI, where vcfg wouldn't be defined if the previous term was true. Walrus fail. Signed-off-by: John Mulligan <[email protected]>
The client.open method is what actually causes the exceptions to be raised so we need to handle it properly. Signed-off-by: John Mulligan <[email protected]>
Add a new more catch-all error type to the varlink interface definition and code. In particular this error should be used by a scope when it can't perform an operation and needs to return something sensible to the client rather than just blowing up. Signed-off-by: John Mulligan <[email protected]>
Add a new context manager that converts exceptions from KMIP and converts them into something keybridge friendly(er). Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
requested review from
Shwetha-Acharya,
anoopcs9,
avanthakkar,
gd and
synarete
anoopcs9
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assortment of small fixes and some error handling improvements based on issues seen when doing some practical testing on a system.