-
Notifications
You must be signed in to change notification settings - Fork 4
smbtorture: Add more smb2 tests #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/retest all |
/retest centos-ci/cephfs.vfs |
@anoopcs9 It looks like https://gitlab.com/samba-team/samba/-/merge_requests/3647 is still pending. I propose that we remove this particular change from this PR and commit the change to add new tests within this PR. You can re-propose the changes to knownfail once the MR above is approved for upstream. |
3a80a62
to
0a5098e
Compare
0a5098e
to
20a8bf7
Compare
Anoop, I noticed that both https://gitlab.com/samba-team/samba/-/merge_requests/3635 and https://gitlab.com/samba-team/samba/-/merge_requests/3649 are now fixed. In that case, can you please remove the tests from the flapping lists and we can proceed with merging the request. |
I noticed that those fixes were supposed to have been fixed last year. |
/test all |
20a8bf7
to
f5671e8
Compare
Signed-off-by: Anoop C S <[email protected]>
f5671e8
to
939ae97
Compare
/test all |
I guess with the changes which went into samba-in-kubernetes/sit-environment#142, can we remove smb2.durable-open.alloc-size from the flapping list for cephfs too? |
Nope, with CephFS it is a different story, see #80. |
Here we update selftest/knownfail as smb2.setinfo is a single test and not a test suite. Hopefully with the next sync of selftest contents from upstream we get it resolved via !3647.
The pull request depends on !3635 and !3649 in order to successfully pass smb2.durable-open and smb2.delete-on-close-perms respectively.