Skip to content

Conversation

anoopcs9
Copy link
Collaborator

Here we update selftest/knownfail as smb2.setinfo is a single test and not a test suite. Hopefully with the next sync of selftest contents from upstream we get it resolved via !3647.

The pull request depends on !3635 and !3649 in order to successfully pass smb2.durable-open and smb2.delete-on-close-perms respectively.

@spuiuk
Copy link
Collaborator

spuiuk commented Jun 6, 2024

/retest all

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Jun 10, 2024

/retest centos-ci/cephfs.vfs

@anoopcs9 anoopcs9 requested a review from spuiuk June 11, 2024 10:33
@spuiuk
Copy link
Collaborator

spuiuk commented Jun 28, 2024

@anoopcs9 It looks like https://gitlab.com/samba-team/samba/-/merge_requests/3647 is still pending. I propose that we remove this particular change from this PR and commit the change to add new tests within this PR. You can re-propose the changes to knownfail once the MR above is approved for upstream.

@anoopcs9 anoopcs9 force-pushed the add-more-smb2-tests branch 2 times, most recently from 3a80a62 to 0a5098e Compare August 2, 2024 11:09
@anoopcs9 anoopcs9 force-pushed the add-more-smb2-tests branch from 0a5098e to 20a8bf7 Compare July 28, 2025 13:37
@spuiuk
Copy link
Collaborator

spuiuk commented Sep 17, 2025

Anoop, I noticed that both https://gitlab.com/samba-team/samba/-/merge_requests/3635 and https://gitlab.com/samba-team/samba/-/merge_requests/3649 are now fixed. In that case, can you please remove the tests from the flapping lists and we can proceed with merging the request.

@spuiuk
Copy link
Collaborator

spuiuk commented Sep 17, 2025

I noticed that those fixes were supposed to have been fixed last year.

@spuiuk
Copy link
Collaborator

spuiuk commented Sep 18, 2025

/test all

@spuiuk
Copy link
Collaborator

spuiuk commented Oct 6, 2025

/test all

@spuiuk
Copy link
Collaborator

spuiuk commented Oct 6, 2025

I guess with the changes which went into samba-in-kubernetes/sit-environment#142, can we remove smb2.durable-open.alloc-size from the flapping list for cephfs too?

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Oct 6, 2025

I guess with the changes which went into samba-in-kubernetes/sit-environment#142, can we remove smb2.durable-open.alloc-size from the flapping list for cephfs too?

Nope, with CephFS it is a different story, see #80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants