Run with profile mode by default #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When samba is compiled without profile support or smbd running without 'smbd profiling level = on' there is no profile information which smbstatus exports. In such cases, do not export any profile metric via Prometheus exporter. Signed-off-by: Shachar Sharon <[email protected]>
By default, run smbmetrics with profile-exporter enabled (if present). Allow user to disable it by passing explicit '--no-profile' flag at command line. Signed-off-by: Shachar Sharon <[email protected]>
Update doc to reflect default run mode. Signed-off-by: Shachar Sharon <[email protected]>
Whenever running 'smbstatus' as child process with, we also expect it to run properly. Send a proper log message in case of failure via the bridge layer (SMBInfo, SMBProfileInfo). Signed-off-by: Shachar Sharon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have profile-mode enabled by default. If profile information is not available from smbd, export only base metrics.