Skip to content

metrics: export using explicit values #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

metrics: export using explicit values #18

merged 2 commits into from
Feb 25, 2025

Conversation

synarete
Copy link
Collaborator

Labels can not be used in order to plot graphs based on metrics. Export various smb profile stats as explicit metric values, where only the operation name is used as label.

Use helper mapping from operation name to entry when emitting output metrics in order to avoid boilerplate code.

@synarete
metrics: export using explicit values
0a8407c 
Labels can not be used in order to plot graphs based on metrics. Export
various smb profile stats as explicit metric values, where only the
operation name is used as label.

Use helper mapping from operation name to entry when emitting output
metrics in order to avoid boilerplate code.

Signed-off-by: Shachar Sharon <[email protected]>
phlogistonjohn
phlogistonjohn reviewed Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While nothing looks wrong my lack of direct experience with some of this API has me wondering.

One useful thing might be to do a before and after example curl run of the endpoint to help me/us see what is changing.

@synarete
Copy link
Collaborator Author

While nothing looks wrong my lack of direct experience with some of this API has me wondering.

One useful thing might be to do a before and after example curl run of the endpoint to help me/us see what is changing.

You have a point here -- I forgot to update the README.md file with the proper changes. Will add another commit on-top.

phlogistonjohn
phlogistonjohn approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the sample output, it does help clarify how things should work now. LGTM

avanthakkar
avanthakkar approved these changes Feb 25, 2025
View reviewed changes
Copy link

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@synarete synarete merged commit 7c009e8 into samba-in-kubernetes:main Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

+1 more reviewer

@avanthakkar avanthakkar avanthakkar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@avanthakkar avanthakkar

@phlogistonjohn phlogistonjohn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@synarete @avanthakkar @phlogistonjohn