Skip to content

Conversation

synarete
Copy link
Collaborator

Update to latest (from Feb 2025) golang version.

Update to latest (from Feb 2025) golang version.

Signed-off-by: Shachar Sharon <[email protected]>
@synarete synarete requested a review from anoopcs9 May 18, 2025 11:24
Copy link
Contributor

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take this opportunity to match this version bump by updating the setup-go GitHub action in our workflow yaml to v5. To keep us updated with the minimum version supported please use the oldstable alias as described in the docs.

@synarete
Copy link
Collaborator Author

Let's take this opportunity to match this version bump by updating the setup-go GitHub action in our workflow yaml to v5. To keep us updated with the minimum version supported please use the oldstable alias as described in the docs.

Good point! will add another commit within this PR

Align github workflow with recommended[1] setup-go and go-version
settings.

[1] https://github.com/actions/setup-go?tab=readme-ov-file#using-stableoldstable-aliases

Signed-off-by: Shachar Sharon <[email protected]>
@xhernandez
Copy link

Let's take this opportunity to match this version bump by updating the setup-go GitHub action in our workflow yaml to v5. To keep us updated with the minimum version supported please use the oldstable alias as described in the docs.

Using stable or oldstable will automatically switch versions when a new one is released. Couldn't this make identification of failures harder if the cause of the failure is some change introduced in the latest version ? on the other side, if we use a fixed version we'll always need to update it manually. I'm not sure what's better.

@synarete
Copy link
Collaborator Author

Let's take this opportunity to match this version bump by updating the setup-go GitHub action in our workflow yaml to v5. To keep us updated with the minimum version supported please use the oldstable alias as described in the docs.

Using stable or oldstable will automatically switch versions when a new one is released. Couldn't this make identification of failures harder if the cause of the failure is some change introduced in the latest version ? on the other side, if we use a fixed version we'll always need to update it manually. I'm not sure what's better.

We want to align with the common conventions of the Golang community. Unfortunately, it looks like an ever-moving target and will probably require some extra attention. As an example, I just realized that we would also need to upgrade some of the tooling we use, and therefore this PR is in-complete. I will close it and open a new one with all proper changes.

@synarete synarete closed this May 19, 2025
@synarete
Copy link
Collaborator Author

Need to do few more upgrades (tools) so will issue a new PR.

@anoopcs9
Copy link
Contributor

Let's take this opportunity to match this version bump by updating the setup-go GitHub action in our workflow yaml to v5. To keep us updated with the minimum version supported please use the oldstable alias as described in the docs.

Using stable or oldstable will automatically switch versions when a new one is released. Couldn't this make identification of failures harder if the cause of the failure is some change introduced in the latest version ? on the other side, if we use a fixed version we'll always need to update it manually. I'm not sure what's better.

We want to align with the common conventions of the Golang community. Unfortunately, it looks like an ever-moving target and will probably require some extra attention. As an example, I just realized that we would also need to upgrade some of the tooling we use, and therefore this PR is in-complete. I will close it and open a new one with all proper changes.

I agree with @synarete. We have to deal with it using proper upgraded tool set as part of our CI runs.

@synarete synarete deleted the ss-image-golang-124 branch May 22, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants