-
Notifications
You must be signed in to change notification settings - Fork 5
image: use golang builder 1.24 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update to latest (from Feb 2025) golang version. Signed-off-by: Shachar Sharon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take this opportunity to match this version bump by updating the setup-go
GitHub action in our workflow yaml to v5. To keep us updated with the minimum version supported please use the oldstable
alias as described in the docs.
Good point! will add another commit within this PR |
Align github workflow with recommended[1] setup-go and go-version settings. [1] https://github.com/actions/setup-go?tab=readme-ov-file#using-stableoldstable-aliases Signed-off-by: Shachar Sharon <[email protected]>
Using |
We want to align with the common conventions of the Golang community. Unfortunately, it looks like an ever-moving target and will probably require some extra attention. As an example, I just realized that we would also need to upgrade some of the tooling we use, and therefore this PR is in-complete. I will close it and open a new one with all proper changes. |
Need to do few more upgrades (tools) so will issue a new PR. |
I agree with @synarete. We have to deal with it using proper upgraded tool set as part of our CI runs. |
Update to latest (from Feb 2025) golang version.