Project update #21
Merged
Project update #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade project to support the latest two version of golang. Signed-off-by: Shachar Sharon <[email protected]>
synarete
force-pushed
the
ss-project-update
branch
from
2206764 to
6cb04e9
Compare
anoopcs9
approved these changes
May 19, 2025
hack/install-tools.sh
Outdated
|
|
||
| _install_yq() { | ||
| _install_tool github.com/mikefarah/yq/v4@v4.23.1 | ||
| _install_tool github.com/mikefarah/yq/v4@v4.45.3 |
There was a problem hiding this comment.
nit: upstream says v4.45.4 as the latest version.
Using latest yq release. Signed-off-by: Shachar Sharon <[email protected]>
Using latest 'revive' release. Signed-off-by: Shachar Sharon <[email protected]>
Upgrade to latest golangci-lint version. Used migration-guide[1] to adjust golangci configuration file to new version. [1] https://golangci-lint.run/product/migration-guide/ Signed-off-by: Shachar Sharon <[email protected]>
Align github workflow with recommended[1] setup-go and go-version settings. [1] https://github.com/actions/ \ setup-go?tab=readme-ov-file#using-stableoldstable-aliases Signed-off-by: Shachar Sharon <[email protected]>
Update to latest (from Feb 2025) golang version. Signed-off-by: Shachar Sharon <[email protected]>
synarete
force-pushed
the
ss-project-update
branch
from
6cb04e9 to
511f6f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update project to newer golang version an tools. Use golang 1.24 for container image.