main: allow passing --address to set bind address #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new --address option that takes an IP address values (v4 or v6) to specify exactly what address to listen on. Internally, a slice of IP objects is used but we currently only support binding to one of them. Checking for an empty slice is easy and there's a chance we will want multiple listeners in the future but to keep things somewhat simple the CLI and listener only allows for one. The goal of this feature is to eventually support colocation of smb services on a single node by having one set of smb related services bind only to a given address and a different set of smb services bind only to a different address on the same host. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-bind-addrs
branch
from
7a62d51 to
c5438ef
Compare
|
@synarete ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new --address option that takes an IP address values (v4 or v6) to specify exactly what address to listen on.
Internally, a slice of IP objects is used but we currently only support binding to one of them. Checking for an empty slice is easy and there's a chance we will want multiple listeners in the future but to keep things somewhat simple the CLI and listener only allows for one.
The goal of this feature is to eventually support colocation of smb services on a single node by having one set of smb related services bind only to a given address and a different set of smb services bind only to a different address on the same host.